Update template descriptions with more detail #48934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
mtias,
jameskoster,
justintadlock,
Mamaduka and
ndiego
|
I left a comment on the issue, pasting in here: 404The 'typo' part is a little ambiguous... when the user makes a typo where, adding a comment, logging in, searching? Should we embellish that, or maybe get rid of it? AttachmentIt feels a little overly technical / jargony. Do we need that "uploaded to a post" part at the end?
Home
Should 'for' be 'as'?
What do you think @justintadlock ? |
|
Size Change: +9 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
@ntsekouras I'm still seeing the old descriptions for Index and Taxonomy 🤔 The rest are working well. |
Hm.. you shouldn't. I'm seeing the new ones.. |
|
on 404 - "Displays when a visitor views a non-existant page, such as a dead link or when the visitor makes a typo." better, maybe "...such as a dead link or a mistyped URL ? |
|
That seems good to me @bph :) @ntsekouras could something like this be cached? 🤔 descriptions.mp4 |
This is saved in the template. If a template didn't exist in a theme(like |
justintadlock
approved these changes
Mar 8, 2023
|
Tested well for me and all the strings look correct when compared with the original list, and subsequent discussion. Core port at WordPress/wordpress-develop#4204 |
andrewserong
approved these changes
Mar 9, 2023
|
@jameskoster - there is a question here about whether this is an urgent enough change to sneak past the soft string freeze which is already past - I am thinking you are best placed to answer this in @ntsekouras absence? |
Mamaduka
added
[Type] Copy
|
They are backporting this into the |
Mamaduka
added
Backport to WP 6.7 Beta/RC
Mamaduka
pushed a commit
that referenced
this pull request
Mar 9, 2023
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 861df24 |
Mamaduka
removed
the
Backport to WP 6.7 Beta/RC
|
@glendaviesnz I'd say it's fairly important. Reason being that template descriptions are given elevated prominence in the Site Editor now, and the current descriptions are not optimised for this:
|
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 9, 2023
The template descriptions in `get_default_block_template_types()` are updated to add more details. Why? These descriptions are now more prominent in 6.2 to provide a better UX experience with more helpful information. References: * [WordPress/gutenberg#48934 Gutenberg PR 48934] Follow-up to [54761], [54104], [54269], [53129], [52331], [52062]. Props ntsekouras, andrewserong, bph, davidbaumwald, greenshady, glendaviesnz, hellofromTonya, jameskoster, mamaduka, peterwilsoncc, sabernhardt, SergeyBiryukov. Fixes #57892. git-svn-id: https://develop.svn.wordpress.org/trunk@55500 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 9, 2023
The template descriptions in `get_default_block_template_types()` are updated to add more details. Why? These descriptions are now more prominent in 6.2 to provide a better UX experience with more helpful information. References: * [WordPress/gutenberg#48934 Gutenberg PR 48934] Follow-up to [54761], [54104], [54269], [53129], [52331], [52062]. Props ntsekouras, andrewserong, bph, davidbaumwald, greenshady, glendaviesnz, hellofromTonya, jameskoster, mamaduka, peterwilsoncc, sabernhardt, SergeyBiryukov. Fixes #57892. Built from https://develop.svn.wordpress.org/trunk@55500 git-svn-id: http://core.svn.wordpress.org/trunk@55032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Mar 9, 2023
The template descriptions in `get_default_block_template_types()` are updated to add more details. Why? These descriptions are now more prominent in 6.2 to provide a better UX experience with more helpful information. References: * [WordPress/gutenberg#48934 Gutenberg PR 48934] Follow-up to [54761], [54104], [54269], [53129], [52331], [52062]. Props ntsekouras, andrewserong, bph, davidbaumwald, greenshady, glendaviesnz, hellofromTonya, jameskoster, mamaduka, peterwilsoncc, sabernhardt, SergeyBiryukov. Fixes #57892. Built from https://develop.svn.wordpress.org/trunk@55500 git-svn-id: https://core.svn.wordpress.org/trunk@55032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related: #48290
I'm not sure if we close the linked issue, as the descriptions have been made a bit shorter, to see if we can include this to
6.2. The main technical problem with the original suggestions is that they need to have paragraphs/break lines and would involve much more thought and work. After looking at the above, I'm thinking maybe a REST API change in templates might be good, to treatdescriptionfield liketitlewithraw and rendered..Notes
Some of the descriptions are still quite long and might not be the best fit with the current UIs. An alternative could be to even update some of them for now, instead of updating all..
Also it's important to note that if this lands in time for RC1 tomorrow, any updates to the strings will not be possible due to the
string freeze.Testing Instructions
See the new templates description where are shown, like:
templateslist in site editoraddbutton to create a new template