Update Gallery block to use consistent 40px components #49101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though it's not supported just yet; follow up PR.
richtabor
added
[Feature] Inspector Controls
|
Size Change: +19 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2a3c26f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4428032283
|
|
I have the #49105 PR which will allow for the RangeControl's number input to also leverage the 40px consistency—which will bring the Gallery block's Inspector looking like this:
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Gallery block controls to use
size="__unstable-large"in support of #46734 (and pointed out here).RangeControl does not support this currently, but I added the prop so that when it does, we get that already.
Why?
Consistency.
How?
Adds the
sizeprop to the Gallery block's Inspector.Testing Instructions
Screenshots or screencast
Before:
After: