Add Post Date block variation for Post Modified Date #49111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +115 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0f5307a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4429947556
|
carolinan
approved these changes
Mar 16, 2023
|
Seems useful enough. Not a strong opinion, but is |
|
I echo the sentiments around the name, and personally see the 'Post' prefix as the main culprit. Obviously it's a wider issue, but it's not very helpful to encounter blocks like "Post Title", "Post Content", "Post Author", when you're editing a page, or a product. Without those prefixes we might have things like:
But until we get there, "Post Modified Date" seems acceptable despite the quirks. |
yep, i agree (see my original issue) #49093 it is dedicated to core publication features (page, post) only. I proposed Dates as single block in my original issue. |
Yes, it works for any post type. It's essentially |
My reasoning too. I'm not directly opposed to "Publish date" and "Modified date". We do have some "theme" blocks that don't have the prefix:
|
|
K.I.S.S :-) no prefix :-) |
|
Removing the prefix is definitely something to handle separately. I'd stick with the current convention for this PR. |
|
Hey Rich! @richtabor This is great! Thank you for creating this Post Modified Date block! Sometimes I want to add a prefix. For a date modified block I might want to add a this post was modified -date-.
Comparing to Post Modified Date block. I miss being able to add Post was modified -date- to this Post Modified Date block. |
|
That's interesting, though you could wrap it in a Row block with a Paragraph block of that text. |
|
Yeah. I also thought about that. It does add a higher complexity to it. Anyhow. I am exiting out of this PR now. Thanks again for creating the Post Modified Date block Rich! |
|
@paaljoachim / @richtabor |
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a block variation for the core/post-date block so that one can search for, and directly add, the modified date to a template. It's the same block—just easier to add. Closes #49093.
Why?
Makes it easier to discover and add the modified date, instead of adding a post date block, then opening the Block Inspector and toggling the displayType attribute.
How?
Testing Instructions
Screenshots or screencast