Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back revisions button for template parts #49163

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Bring back revisions button for template parts #49163

merged 1 commit into from
Mar 17, 2023

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Mar 17, 2023 •
edited
Loading

What?

After preparing Gutenberg for the release of the 6.2 core version some files were moved in the lib folder. This resulted in a typo which hid the button for revisions in the template part editor.

Why?

To bring the button back.

How?

Correct the typo.

Testing Instructions

  1. Open a template part
  2. Reset customisations
  3. Save
  4. Change something
  5. Save
  6. Change something else
  7. Save
  8. In the inspector Template tab you should see the revisions button

@draganescu draganescu requested a review from scruffian March 17, 2023 15:16
@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Mar 17, 2023
@draganescu draganescu marked this pull request as ready for review March 17, 2023 15:19
jeryj
jeryj approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@jeryj jeryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@scruffian scruffian enabled auto-merge (squash) March 17, 2023 15:26
@scruffian scruffian merged commit de07e4d into trunk Mar 17, 2023
@scruffian scruffian deleted the fix/missing-revisions-button-template-parts branch March 17, 2023 15:40
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 17, 2023
@ramonjd ramonjd mentioned this pull request Jun 5, 2023
Closed
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@femkreations femkreations mentioned this pull request Jul 10, 2023
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeryj jeryj jeryj approved these changes

@scruffian scruffian scruffian approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs User Documentation Needs new user documentation [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
4 participants
@draganescu @scruffian @jeryj @femkreations