Search block: fix overflow width #49192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
the
[Block] Search
|
Size Change: -3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8b0ca5693485050414593644f9c3a67f7649c6b5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4478378140
|
There was a problem hiding this comment.
Thanks for fixing this @madhusudhand 👍
This tests pretty well on the surface for me using the example block content. If we want all the search block configurations to line up, the option without a search button is still out of whack. Maybe we could address that in a follow-up to this?
I had a couple of questions or suggested tweaks that I've left as inline comments that we might wish to address before landing this.
madhusudhand
force-pushed
the
fix-39946
branch
2 times, most recently
from
8b0ca56
to
2cf4eca
Compare
Sure. Thanks for pointing. I will take it up in a follow-up. |
aaronrobertshaw
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Thanks for iterating on this @madhusudhand 👍
It tests well for me.
With updating the "no button" version and adding an input outline for the "button-inside" layout, as follow-ups. I think this is ready to go.
ryanwelcher
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes the search block overflow width issue for
inside buttonvariant.Before:
After:
With
emunits it still leaves small gaps because it is tied to parent font size. So, updated the units toreminstead.How?
border-boxemtoremTesting Instructions
Fixes: #39946