Group: Fix the 'templateLock' attribute type in deprecations #49205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ntsekouras and
tellthemachines
and removed request for
ajitbohra
Mamaduka
added
[Type] Bug
Mamaduka
commented
Mar 20, 2023
| @@ -50,7 +50,8 @@ const deprecated = [ | |||
| default: 'div', | |||
| }, | |||
| templateLock: { | |||
| type: 'string', | |||
| type: [ 'string', 'boolean' ], | |||
| enum: [ 'all', 'insert', false ], | |||
There was a problem hiding this comment.
I've omitted contentOnly since it was introduced after this deprecation.
|
Size Change: +6 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8cf99d1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4468704939
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49159.
PR updates the
templateLocktype in the latest block deprecation to avoid losing the attribute when it's set tofalse.Testing Instructions
templateLockboolean value is retained.