Plugins: Refactor the 'PluginArea' component to use the sync store #49220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -10 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e34777f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4475841035
|
tyxla
approved these changes
Mar 21, 2023
| setPlugins() { | ||
| this.setState( this.getCurrentPluginsState ); | ||
| } | ||
| const plugins = useSyncExternalStore( store.subscribe, store.getValue ); |
There was a problem hiding this comment.
I think plugins and store could be abstracted to their own usePluginsState hook. Not a huge deal of course, since it's used only in one place.
There was a problem hiding this comment.
I also thought about it. Let’s abstract when there’s another use for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors the
PluginAreacomponent to use theuseSyncExternalStorehook instead of lifecycle methods.Why?
Testing Instructions
Register testing plugin via console:
Screenshots or screencast