Components: Ship TypeScript types #49229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Wow, it’s so close 🎉🎉🎉 That’s quite an achievement, congrats to everyone involved! |
|
I gave this PR a quick look, and types seems to work as expected, at least in VSCode. It would be good to get more eyes on this, especially:
Pinging a few folks in that regard: @gziolo @aaronrobertshaw @andrewserong @noisysocks @sirreal |
ciampo
reviewed
Mar 21, 2023
| @@ -43,7 +43,6 @@ | |||
| "src/**/*.native.js", | |||
| "src/**/react-native-*", | |||
| "src/**/stories/**/*.js", // only exclude js files, tsx files should be checked | |||
| "src/**/test/**/*.js", // only exclude js files, ts{x} files should be checked | |||
| "src/index.js" | |||
There was a problem hiding this comment.
On top of excluding index.js, I wonder if there's any value in renaming it to index.ts ?
There was a problem hiding this comment.
I tried renaming it, let's see if anything breaks
There was a problem hiding this comment.
Nice work on this @mirka ✨
I've only been able to give this a run using VS Code but it's looking good.
✅ Build process completes without issue
✅ Intellisense tooltips show correct info
✅ Go to source definition lands on the correct file and export
tyxla
reviewed
Mar 22, 2023
chad1008
reviewed
Mar 22, 2023
ciampo
force-pushed
the
build-types-components
branch
from
6224b5b to
98e379a
Compare
|
Flaky tests detected in 98e379a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4504205931
|
9 tasks
|
DT removal: DefinitelyTyped/DefinitelyTyped#65213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #35744
Properly ship first-party TypeScript declarations with the
@wordpress/componentspackage.Why?
We were relying on
@types, which could be wrong or outdated.Follow-up: remove types from Definitely Typed
Testing Instructions
npm run build