[RNMobile] Support POST requests #49371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - Automation
fluiddot
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 58c814c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4595244702
|
This was referenced Mar 27, 2023
fluiddot
commented
Mar 29, 2023
| /wp\/v2\/search\?.*/i, | ||
| /oembed\/1\.0\/proxy\?.*/i, | ||
| ], | ||
| POST: [ /wpcom\/v2\/(media)\/.*/i ], |
There was a problem hiding this comment.
Based on this past PR, I realized that we should avoid introducing WPCOM endpoints. However, this restriction affects non-core blocks like Jetpack blocks that heavily rely on WPCOM endpoints. Hence, we should refactor this part and probably define/expand the supported endpoints in Gutenberg Mobile.
There was a problem hiding this comment.
I agree it'd be great if this could be defined in Gutenberg Mobile, I'm not sure if we can justify including the WPCOM endpoint here. @fluiddot, were you thinking of refactoring this specific PR or were you thinking of this being done separately?
There was a problem hiding this comment.
I agree it'd be great if this could be defined in Gutenberg Mobile, I'm not sure if we can justify including the WPCOM endpoint here. @fluiddot, were you thinking of refactoring this specific PR or were you thinking of this being done separately?
@SiobhyB I agree that it's not ideal to introduce a WPCOM endpoint here. Since the PR is related to POST requests, in order to unblock it, I'm thinking to remove this change and work on a separate PR to introduce it via GB-mobile.
There was a problem hiding this comment.
Removal applied in b5d54a6.
There was a problem hiding this comment.
I'm thinking to remove this change and work on a separate PR to introduce it via GB-mobile.
@fluiddot, that makes sense to me! I'll go ahead to approve this PR with that understanding 🙇♀️
There was a problem hiding this comment.
@SiobhyB I created the following PRs to introduce the WPCOM endpoint:
This was referenced Mar 29, 2023
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
WordPressOrgRestApiwordpress-mobile/WordPressKit-iOS#589What?
Support POST requests in
apiFetchfunction.Why?
This change will allow the native version of the editor to make POST requests, currently was limited to GET requests.
How?
A new function called
postRequesthas been added to the React Native bridge. Note that the POST request implementation is mainly handled in the host app.Testing Instructions
Follow the testing instructions from wordpress-mobile/gutenberg-mobile#5596.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A