Post Lock: Fix the avatar position #49421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
General Interface
Mamaduka
commented
Mar 29, 2023
| @@ -15,5 +11,5 @@ | |||
| .editor-post-locked-modal__avatar { | |||
| border-radius: $radius-block-ui; | |||
| margin-top: $grid-unit-20; | |||
| margin-right: $grid-unit-30; | |||
| min-width: initial !important; | |||
There was a problem hiding this comment.
The HStack sets min-width: 0 to all its children. We must override that so the image can take up the entire width.
|
Size Change: -3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c50b379. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4550980655
|
jasmussen
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the avatar position regression in the Post Lock modal.
P.S. It's easier to review code changes by hiding whitespaces - https://github.com/WordPress/gutenberg/pull/49421/files?diff=unified&w=1.
Why?
The modal markup changed recently, and the previous styling wasn't applied. See #47426.
How?
Wraps modal content into an
HStackcomponent.I also pushed minor code quality updates in c50b379.
Testing Instructions
Snippet
Screenshots or screencast
Before
After
