Add color tools to time to read block #49496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
This issue actually highlights a bigger problem with the block. Any global style applied to the paragraph block type will also be applied to this block. This problem would be side-stepped by using the Other alternatives might be altering the selectors used however that might require changes to the paragraph block selectors which could carry significant risk. It's a shame that block's selector is so broad. What downsides do you see to using |
I personally think it'd be ok, and it would match what other similar blocks do. I'll push a commit that does that. |
Sounds like a plan. Is this block still experimental or has it been in a release that people could have used? If so, we'll need a deprecation as well. |
|
It's completely dynamic, so I don't think a deprecation will be needed. I've made the change in 588d465. |
|
Flaky tests detected in 7fca9e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4571283699
|
|
Size Change: +8 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
So it is. I should have looked 🤦 Looks like we'll still need some tests to be updated to expect the new markup. Other than that it tests as advertised for me. As a separate issue, the global styles padding on the Paragraph block doesn't get applied on the frontend if you select a background color on the block. |
t-hamano
reviewed
Mar 31, 2023
There was a problem hiding this comment.
What downsides do you see to using div for this block, less semantic HTML?
I personally think it'd be ok, and it would match what other similar blocks do. I'll push a commit that does that.
I agree with this as well. In the current block system, it may be best to use the div element to unify with other blocks that display post meta.
|
Is this block already released? I found this by chance and can't see it neither in 6.2 or 6.3 beta, using block theme, neither on post editor or site editor. |
|
This block is treated as experimental on the Gutenberg plugin and is not included with WordPress 6.3. Here is the core ticket to add this function: https://core.trac.wordpress.org/ticket/57987 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds color tools to the time to read block
Why?
This brings parity with other similar post blocks.
How?
Adds the color support option.
The only contentious aspect to this is that when applying a background, padding is applied via the
p.has-backgroundclass. This is an inconsistency with other blocks like post author name and post date.Some options:
<div>instead of a<p>in the time to read blockTesting Instructions
Screenshots or screencast