-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: remove unused keyboard shortcut registration code #49553
Conversation
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
Flaky tests detected in 970ff04. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4595306390
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH yes, I refactored that one and missed this 👍
What?
I was just walking past and I noticed some unused code in the site editor.
KeyboardShortcutsRegister
is defined inpackages/edit-site/src/components/keyboard-shortcuts/index.js
, but unused.The same code exists
packages/edit-site/src/components/keyboard-shortcuts/register.js
and is used.I imagine it was refactored into a separate file, but the original code accidentally not removed, maybe a git conflict resolve went wrong.