Small improvements for the Document Overview labelling #49555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Enhancement
|
Size Change: -20 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 126afa7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4605502206
|
|
@afercia Wow, coming after me with the close button. :) I think I changed this at one point when the region labeling was not totally clear. Makes sense to shorten it now. It is always a battle of too much context vs. not enough. I am sure your changes broke a ton of E2E tests though, let me know if you need assistance fixing all of them. |
|
Also, do not forget that there are other sidebars to edit.
Other than the tests and other sidebars, this tests well for me. Thanks. |
|
Tanks @alexstine ❤️ Sure. Thinking it would be good to run an audit of the labelling of several parts of the UI. It's pretty inconsistent. See verbs vs. names for controls in the same component, use of spatial references, use of the verb toggle, lack of context ot too much context, etc. |
afercia
force-pushed
the
update/document-overview-better-labelling
branch
from
70f4966
to
126afa7
Compare
aristath
approved these changes
Apr 4, 2023
This was referenced Apr 5, 2023
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I'd like to propose two quick, small improvements for the Document Overview labelling:
1
Remove a redundant aria-label. Labelling a
divelement that isn't interactive or doesn't have a labelable ARIA role is a bit pointless. Thearia-labelhighlighted in the screenshot below doesn't do anything:2
The close button
aria-label(and tooltip) is way too long. A simpleCloseis enough to communicate the functionality ina meaningful way. Context is already provided by the labeled ARIA region. Shorter is better for speech recognition software users. Also, text that is mostly provided for blind screen reader users should preferably avoid spatial terminology such as 'sidebar': as a blind user, I wouldn't mind whether this region is visually placed on the side, top, bottom or in any other spot of the screen.Why?
See above.
How?
Testing Instructions
Testing Instructions for Keyboard
Xclose button.Close.Screenshots or screencast