List View: Add tests for some of the drag and drop logic #49631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
andrewserong
requested review from
talldan,
apeatling,
ramonjd and
tellthemachines
andrewserong
commented
Apr 6, 2023
| rootClientId: '', | ||
| }, | ||
| { | ||
| blockIndex: 0, |
There was a problem hiding this comment.
Note: this is intentionally blockIndex: 0 because it is at the zero position within its container block.
|
Size Change: 0 B Total Size: 1.35 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 33b3614. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4626268394
|
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add tests for some of the list view logic for drag and drop. In particular, the added tests are for the logic in
getListViewDropTargetwhich determines whether to drop above or below the target block, or inside that block.Why?
I'm currently exploring some ideas surrounding how to drag to a parent level within the list view, and I noticed that I'm hacking around with this function. Before going too much further with that hacking around (being explored over in #49498), I thought I'd have a go at writing a few tests for the current behaviour, to make sure that I don't accidentally break anything.
Note: these tests are arguably testing implementation details — I've tried to keep them as simple as I can, but I'm aware they might not be very easy to read given the structure of the objects. On balance, given that it's hard to write tests for drag and drop behaviour, I think the additions will be helpful, but happy for feedback on this!
How?
getListViewDropTargetisExpandedtoWPListViewDropZoneBlocks, which I forget to do back in List View: Allow dragging underneath collapsed non-empty container blocks #49390Testing Instructions
Check that tests pass, or to test locally, run: