Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fonts API] Allow using font-technologies for variable fonts #49653

Closed
wants to merge 2 commits into from

Conversation

aristath
Copy link
Member

@aristath aristath commented Apr 7, 2023

What?

Allows defining tech for font-families.
Fixes #41158, see comment on #41158 (comment) for details.

Why?

To allow using variable fonts files, while at the same time we keep forward-compatibility with the next-gen formats and font technologies.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Flaky tests detected in 873ffbd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4636521747
📝 Reported issues:

@annezazu annezazu added [Feature] Typography Font and typography-related issues and PRs and removed [Feature] Fonts API labels Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Feature] Typography.

Read more about Type labels in Gutenberg.

@hellofromtonya hellofromtonya added [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Feature] Typography Font and typography-related issues and PRs and removed [Feature] Typography Font and typography-related issues and PRs [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API labels Sep 25, 2023
@hellofromtonya
Copy link
Contributor

This PR is for the deprecated Fonts API. The API does not load into memory when the Font Library is active, which is by default. Thus I think this PR can be closed without merging.

The technical details of it might be something to consider, though the underlying issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fonts API] does not correctly handle variable fonts files in .woff2 format
3 participants