Lodash: Remove _.mapValues() from editor package
#49654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
tyxla
commented
Apr 7, 2023
| const metaAttributes = Object.fromEntries( | ||
| Object.entries( settings.attributes ?? {} ) | ||
| .filter( ( [ , { source } ] ) => source === 'meta' ) | ||
| .map( ( [ attributeKey, { meta } ] ) => [ attributeKey, meta ] ) |
There was a problem hiding this comment.
Already an array of entries, so it's straightforward enough to move the outer mapValues() to an inner, subsequent .map().
| metaAttributes, | ||
| ( metaKey ) => meta[ metaKey ] | ||
| ...Object.fromEntries( | ||
| Object.entries( metaAttributes ).map( |
There was a problem hiding this comment.
metaAttributes is an object, see L119.
|
Size Change: +5 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 536c48f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4637785261
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.mapValues()from the editor package.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Object.fromEntries( Object.entries().map() )as a replacement.Testing Instructions
editcomponent #18960 for more info).