Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Keep Transform Block Test Case to Playwright #49719

Conversation

pooja-muchandikar
Copy link
Contributor

What?

Part of #38851.
Migrate keep-styles-on-block-transforms.test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test:e2e:playwright test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js

@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

I hope you are going great!..

Could you please help me in reviewing this PR?

Thanks!!

@kevin940726
Copy link
Member

@pooja-muchandikar Thanks for the PR! I'll take a look maybe next week. Feel free to ping me again if I forget! 🙇

@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

I hope you are doing great!..

Just a gentle reminder to review the PR and let me know if there are any suggestions/feedbacks.

Thanks!

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR as always! I noticed some places that could leverage the latest best practices. LMK if there's anything that's not clear!

@pooja-muchandikar
Copy link
Contributor Author

Thanks @kevin940726, I will take a look and address the feedbacks!

@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

All feedbacks are addressed and CI also passed! Please take a look and let me know if there are any further feedbacks.

Thanks!

@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

Are there any further feedbacks on this PR?

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 💯 ! Thanks again!

@kevin940726 kevin940726 merged commit ac17761 into WordPress:trunk May 2, 2023
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 2, 2023
@pooja-muchandikar pooja-muchandikar deleted the migrate/keep-styles-on-block-transform-test branch May 2, 2023 02:42
@bph bph added the [Package] E2E Tests /packages/e2e-tests label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants