-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Keep Transform Block Test Case to Playwright #49719
Migrate Keep Transform Block Test Case to Playwright #49719
Conversation
Hi @kevin940726, I hope you are going great!.. Could you please help me in reviewing this PR? Thanks!! |
@pooja-muchandikar Thanks for the PR! I'll take a look maybe next week. Feel free to ping me again if I forget! 🙇 |
Hi @kevin940726, I hope you are doing great!.. Just a gentle reminder to review the PR and let me know if there are any suggestions/feedbacks. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR as always! I noticed some places that could leverage the latest best practices. LMK if there's anything that's not clear!
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
Thanks @kevin940726, I will take a look and address the feedbacks! |
Hi @kevin940726, All feedbacks are addressed and CI also passed! Please take a look and let me know if there are any further feedbacks. Thanks! |
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
Hi @kevin940726, Are there any further feedbacks on this PR? |
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM 💯 ! Thanks again!
What?
Part of #38851.
Migrate keep-styles-on-block-transforms.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/various/keep-styles-on-block-transforms.spec.js