Remove frame shadow in edit view #49767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
General Interface
|
Size Change: +4 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
apeatling
approved these changes
Apr 12, 2023
|
Flaky tests detected in ab05e8c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4680990145
|
bph
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures the frame's shadow is only applied in site view
Why?
It's very hard to see, but the shadow applied for the frame slightly overlaps the top toolbar in edit view. If you look very closely at the screenshot below you might be able to see the result:
How?
CSS.
Testing Instructions
You'll probably need to Inspect to confirm:
box-shadowis applied to.edit-site-layout.is-full-canvas .edit-site-layout__canvas>div.