-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Fix React Native iOS E2E tests #49823
Conversation
Flaky tests detected in 3c239f7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4698721445
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
cda427a
to
7a939c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests have passed after they were re-triggered, and I can confirm the changes make sense to me. Thanks for fixing @geriux! 🥇
What?
This PR fixes the current failures with the React Native E2E iOS tests.
Why?
They're currently failing in
trunk
. I haven't found out why this started happening but it could be something that changed in CI most probably.How?
It updates the macOS runner to
macos-12
, and Xcode to13.3.1
.It also now forces launching the simulator before starting to run the tests, this might be the issue we were having, since booting up the simulator takes up close to 5 minutes.
Testing Instructions
CI checks should pass, maybe re-trigger the iOS tests.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A