Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duotone: add block controls on the inspector #49838

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Duotone: add block controls on the inspector #49838

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8da1330
add a filter slot and insert StylesFiltersPanel on the duotone hook
MaggieCabrera Apr 14, 2023
cf970bc
fixed duotone value and onchange function
MaggieCabrera Apr 14, 2023
af984c0
removed label from slot
MaggieCabrera Apr 14, 2023
057be54
enable custom colors and duotone
MaggieCabrera Apr 14, 2023
f96d202
fix custom colors on inspector panel
MaggieCabrera Apr 18, 2023
799269e
changed the panel to act as a dropdown
MaggieCabrera Apr 19, 2023
b8f60bc
disable custom duotone on GS
MaggieCabrera Apr 19, 2023
aabd119
removed border of popover
MaggieCabrera Apr 19, 2023
6e7e6ec
use classnames that are component specific
MaggieCabrera Apr 19, 2023
3b5bb9a
simplify LabeledColorIndicator
MaggieCabrera Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/edit-site/src/components/global-styles/filters-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ export default function FiltersPanel( { name } ) {
inheritedValue={ inheritedStyle }
value={ style }
onChange={ setStyle }
settings={ settings }
settings={ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should memoize this object (depends on how it's used internally)

...settings,
color: {
...settings.color,
customDuotone: false, //TO FIX: Custom duotone only works on the block level right now
},
} }
/>
);
}