Fix quick inserter going off-screen in some situations #49881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shift prop to quick inserter to keep it within the viewport
talldan
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Mamaduka
pushed a commit
that referenced
this pull request
May 8, 2023
- Add shift prop to quick inserter to keep it within the viewport
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 1f39704 |
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49878
This issue is a little surprising, it seems like something that should have been working before, but I can't see where it could have regressed.
How?
Add the shift prop to the dropdown
Testing Instructions
Expected: the inserter popover should be on-screen
In trunk: it can go off-screen
Screenshots or screencast
Before
After