Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Port To WP_TESTS_DOMAIN #49883

Merged
merged 9 commits into from
Apr 20, 2023
Merged

Add Port To WP_TESTS_DOMAIN #49883

merged 9 commits into from
Apr 20, 2023

Commits on Apr 17, 2023

  1. Added Port Addition/Replacement Function

    This new function will allow us to add/replace ports in
    certain `wp-config.php` values.
    ObliviousHarmony committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f8bfb1a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    a4dc90f View commit details
    Browse the repository at this point in the history
  2. Always Use WP_SITEURL When Configuring WordPress

    Since `WP_SITEURL` already contains the port in both the
    development and test environments, there is no reason to
    try and construct the URL with the port. Additionally, it is
    more accurate to use the test environment's `WP_SITEURL`
    since that's what WordPress will expect due to the constant.
    ObliviousHarmony committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0f6388d View commit details
    Browse the repository at this point in the history
  3. Automatically Add Port To WP_TESTS_DOMAIN

    Tests should use the `WP_TESTS_DOMAIN` constant to
    construct URLs in tests. This poses a problem, however,
    because the port will be part of the URL in test environments.
    In my review of WordPress Core and WooCommerce, adding
    the port to `WP_TESTS_DOMAIN` should not break anything
    and will make the container more resilient to port customizations.
    ObliviousHarmony committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b893665 View commit details
    Browse the repository at this point in the history
  4. Removed Hardcoded localhost From PHPUnit Tests

    To add resiliency to the test suite, we should use `WP_TESTS_DOMAIN`
    instead of hardcoding the domain and port in the URLs.
    ObliviousHarmony committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0ddc704 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bf4fee3 View commit details
    Browse the repository at this point in the history
  6. Style Fixes

    ObliviousHarmony committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6ce58ff View commit details
    Browse the repository at this point in the history
  7. Update CHANGELOG.md

    ObliviousHarmony authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3aa9e17 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Configuration menu
    Copy the full SHA
    f3aadee View commit details
    Browse the repository at this point in the history