Add parameters to custom-scrollbars-on-hover #49892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] List View
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 18, 2023
|
Thanks for splitting this one out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds parameters to the
custom-scrollbars-on-hovermixin.Why?
This will be useful for both #49793 and #49793. This removes the change from those more complex PRs so we can at least get this improvement in.
How?
Extracts two variables into parameters so that they can be customised by different implementations.
Testing Instructions
Screenshots or screencast