Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frame resizing #49910

Merged
merged 35 commits into from
May 19, 2023
Merged

Update frame resizing #49910

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
8e9c1af
frame resizer centered
SaxonF Apr 19, 2023
0441dba
Use a lerp function to modify the height of the frame.
mtias Apr 24, 2023
43019aa
Make the frame full screen when the user resizes it to the left.
mtias Apr 24, 2023
63e5509
Ensure the frame grows only to the left when going above its size.
mtias Apr 24, 2023
77d55c4
Disable user selection while resizing the frame.
mtias Apr 24, 2023
b08b57a
Make it easier to grab the handle.
mtias Apr 25, 2023
17becce
Switch to setTimeout and set a fixed resizeRatio.
mtias Apr 25, 2023
59bfa2f
Modify oversized calculation to reduce resizing bug.
mtias Apr 25, 2023
d8dd107
Avoid timer
mirka May 5, 2023
6322c3c
Temp working
mirka May 8, 2023
1934811
Clean up CSS
mirka May 8, 2023
dbb51f9
More cleanup
mirka May 8, 2023
05c49fc
Refactor lerpy parts
mirka May 8, 2023
dc89a28
More cleanup
mirka May 8, 2023
0d19489
Rename `isFull` to `isFullWidth`
mirka May 8, 2023
602e612
Improve maintainability
mirka May 8, 2023
bdc1732
More cleanup
mirka May 8, 2023
34ccb00
Match component classnames
mirka May 8, 2023
0a2cb41
Invert control for flex changes
mirka May 9, 2023
b69ee87
Calculate fluid resize ratio
mirka May 10, 2023
3bb9c10
Prevent React re-render loop warning
mirka May 10, 2023
3ef1855
Always show handle when resizing
mirka May 10, 2023
a742569
Maintain resizing cursor when resizing
mirka May 10, 2023
48658ca
Improve code comments
mirka May 10, 2023
cd5bcc4
Exclude `ListPage` from ResizableFrame
mirka May 10, 2023
09bc6fd
Use CSS var for accent color
mirka May 10, 2023
d518f0e
Handle spinner gracefully
mirka May 10, 2023
ee461b9
Lift loading state so resizing can be disabled
mirka May 10, 2023
b85a344
Change max width for less jankiness
mirka May 10, 2023
334b643
Remove outdated padding animation
mirka May 10, 2023
44828f7
Clean up magic numbers
ciampo May 18, 2023
db6330c
Update saveSiteEditorEntities() locators
WunderBart May 19, 2023
929e903
Update StyleBook.open() locators
WunderBart May 19, 2023
5d53981
Quickfix: Wait until load spinner is gone
mirka May 19, 2023
a2bf020
Revert to class-based save detection
mirka May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/e2e-test-utils-playwright/src/editor/site-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ export async function saveSiteEditorEntities( this: Editor ) {
.getByRole( 'button', { name: 'Save', exact: true } )
.click();

// Wait for the saved status.
await editorTopBar.getByRole( 'button', { name: 'Saved' } ).waitFor();
// A role selector cannot be used here because it needs to check that the `is-busy` class is not present.
await this.page
.locator( '[aria-label="Editor top bar"] [aria-label="Saved"].is-busy' )
Copy link
Member

@WunderBart WunderBart May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I think it would be good to address this on an implementation level, though (not a scope of this PR). The button should probably say Saving, not Saved as long as the request is pending (.is-busy ATM). cc @kevin940726

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I totally forgot to TODO comment this. Thanks!

Relevant component file

.waitFor( {
state: 'hidden',
} );
}