Borders: Maintain radius in Global Styles #49950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +29 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Apr 20, 2023
|
Thanks for the quick review.
Agreed. This is a side effect of merging the block editor and global styles panels. To be able to adjust the resulting style object for global styles only, we have the entire styles object here and no obvious place for a separate An alternative would be to revisit an earlier approach where we passed a prop down to the underlying panel that actually manages the separate controls. At that level, we could handle the changes more independently.
I'll get this merged in the short term then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #49738
What?
Fixes a regression introduced in #49738. When the global styles specific logic for border color, width, and style was moved to the global styles panel, maintaining the radius value wasn't accounted for.
Why?
Without this fix you can't set a border-radius in Global Styles.
How?
Now the onChange handler will only pass the border color, width, style, or side objects through to the function applying a border style fallback. The radius is deconstructed and added back to the new border style to be set.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-04-20.at.6.31.30.pm.mp4
Screen.Recording.2023-04-20.at.6.29.33.pm.mp4