[Social Icon]: Update the link and mail block variation's icons
#49952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used from WP icons
|
Looks good, thanks for doing this. I hate to say this, but should we also update the email icon while we're there? We would need to design one, one doesn't exist for this yet. But the thinner stroke width of the new link icon stands out compared to the more solid email. |
Sounds good! I just opened the PR because of the nuances of this block, so anyone that can provide the new icon is welcome! |
|
Size Change: -436 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
How about this? That's this: Probably no need to add that to the icon library, it's just a replacement for the social link SVG. here it is shown next to the link:
|
ntsekouras
changed the title
link and mail block variation's icons
jasmussen
approved these changes
Apr 20, 2023
|
Flaky tests detected in b6320fa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4752912310
|
|
Do we definitely want to use the WordPress icons on the frontend? Probably not a big deal, but I'm not sure if we're doing this elsewhere? |
|
The mail icon likely has uses outside of the social icons block, it'd be good to add that one to the main package in a follow up. |
I think what we want is to use good icons on the frontend. The existing ones are not good. I can say that, as I designed them, a lifetime ago 🙈 |
|
So I guess we can land this for now? 😄 |
jameskoster
added
the
Needs Figma Update
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the icon of the
linkSocial Link's block variation to match thelinkicon of@wordpress/icons. For security reasons(svg) this block is rendered server side and we can't actually use it directly from the JS package.So, I just updated the current icon's path to match the
link's path from the JS package.It also updates the
mailvariation's icon.Testing Instructions
linkand amailScreenshots or screencast