Fix the condition for the modal to choose the initial template pattern #49954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
changed the title
Mamaduka
changed the title
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
youknowriad,
jameskoster,
afercia and
jorgefilipecosta
|
Size Change: -1 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49548.
PR swaps
__experimentalGetDirtyEntityRecordswithhasEditsForEntityRecordto check unsaved template changes.Commit 3098a57.
The remaining commits fix minor issues in the file.
Why?
The
__experimentalGetDirtyEntityRecordscheck is too broad for this condition.Testing Instructions
The original PR (#46248) doesn't include extensive instructions for the testing. I also tried to test different cases, but I would appreciate the help here to avoid regressions.
Screenshots or screencast
CleanShot.2023-04-20.at.15.29.44.mp4