Experiment: Add dynamic time to comment date with interactivity api #49955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Block] Comment Date
SantosGuillamot
changed the title
|
Size Change: +8 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 67afc66. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4754180568
|
|
@dmsnell suggested a different (and simpler) approach; don't include the whole
Up to this point, decide whether to make it dynamic also for times > 1 hour. If so, also include something like:
The rest doesn’t need to be dynamic as it’d never be updated in the client. |
My only note here is that for the functionality that requires many highly dynamic translations, the usage of |
|
Closing this PR as it was just meant to be an experiment. It can always be reopened/reused in the future. |
gziolo
deleted the
experiment/comment-date-dynamic-time-with-interactivity-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with @gziolo
What?
Experiment using the Interactivity API to update the time that has passed since a comment was submitted.
The Interactivity API is an experimental API to add frontend interactivity to blocks. More info in this post and in GitHub
Why?
To see what is needed to integrate this use case.
How?
This branch is on top of the Experiment: use the Interactivity API to do client-side form submissions for practical reasons.
Before explaining how this was implemented, some considerations we had in mind:
How we implemented this:
get_comment_time() functionindata-wp-context.data-wp-initdirective and triggereffects.core.checkDiff, which runs a function namedmakeTheUpdatewith asetTimeOutdepending if it is seconds, minutes, or hours.makeTheUpdatefunction to change the time diff and the text depending on if it is seconds, mins, or hours. That information is stored in thecontext.data-wp-textto show the time difference updated bymakeTheUpdate.@wordpress/i18npackage to handle the translations. We are aware this package is not intended for the frontend, but it was enough for this experiment.And here you have a video with the demo and some explanations:
https://www.loom.com/share/e42ba81012454640ad239c63c5c25523