Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behaviors UI #49972

Merged
merged 61 commits into from
May 24, 2023
Merged

Behaviors UI #49972

merged 61 commits into from
May 24, 2023

Commits on May 23, 2023

  1. Add behaviors to the core theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bd53de2 View commit details
    Browse the repository at this point in the history

  2. Add behaviors to json schemas for theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bd43bf6 View commit details
    Browse the repository at this point in the history

  3. Add a behaviors panel

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e1dd737 View commit details
    Browse the repository at this point in the history

  4. Remove the changes to theme.json schema

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8b84a22 View commit details
    Browse the repository at this point in the history

  5. Add behaviors to the VALID_SETTINGS in class-wp-theme-json-gutenberg.php

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d5dbc1c View commit details
    Browse the repository at this point in the history

  6. Add the first (still broken) version of the lightbox settings

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    037d669 View commit details
    Browse the repository at this point in the history

  7. WIP: Added a SelectControl for the behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8f62d34 View commit details
    Browse the repository at this point in the history

  8. Format PHP

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    62b6217 View commit details
    Browse the repository at this point in the history

  9. Format correctly again

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    edfd7d1 View commit details
    Browse the repository at this point in the history

  10. Use the props.name when getting the behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8ee4065 View commit details
    Browse the repository at this point in the history

  11. Add initial e2e tests

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    594224b View commit details
    Browse the repository at this point in the history

  12. Update the withBehaviors description

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd6fe36 View commit details
    Browse the repository at this point in the history

  13. Cleaned up behaviors.js

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    da4a5ad View commit details
    Browse the repository at this point in the history

  14. Update e2e tests to check visibility

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2958fd1 View commit details
    Browse the repository at this point in the history

  15. Update core-blocks doc with behaviors attribute

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0a68bea View commit details
    Browse the repository at this point in the history

  16. Update fixtures with new lightbox attribute

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd08928 View commit details
    Browse the repository at this point in the history

  17. Add a new theme for e2e tests

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4e03e0d View commit details
    Browse the repository at this point in the history

  18. Change theme.json to include settings.behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    92b6e6c View commit details
    Browse the repository at this point in the history

  19. Remove default behavior value from block.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ffa881e View commit details
    Browse the repository at this point in the history

  20. Minor fix to the implementation

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    99c964b View commit details
    Browse the repository at this point in the history

  21. Add more e2e tests

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7f7db2c View commit details
    Browse the repository at this point in the history

  22. Create a selector for behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5e5ff9a View commit details
    Browse the repository at this point in the history

  23. Add a filter to load behaviors on the server from the theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ad20b64 View commit details
    Browse the repository at this point in the history

  24. Add behaviors on the top-level in core theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d16266b View commit details
    Browse the repository at this point in the history

  25. Use the behaviors in the hooks

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0982d9f View commit details
    Browse the repository at this point in the history

  26. Update the comment

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0ef7b5e View commit details
    Browse the repository at this point in the history

  27. Update the comment in behaviors.js

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e75fd87 View commit details
    Browse the repository at this point in the history

  28. Update fixtures and e2e

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    f6414f9 View commit details
    Browse the repository at this point in the history

  29. Prevent mobile test gutenberg error (temporary - not the best solution)

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    31c0623 View commit details
    Browse the repository at this point in the history

  30. Add priority on filter

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ee3701f View commit details
    Browse the repository at this point in the history

  31. Fix php standards

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a0ac748 View commit details
    Browse the repository at this point in the history

  32. Found a much better way to fix php tests

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1dd6df1 View commit details
    Browse the repository at this point in the history

  33. Small refactor

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a737200 View commit details
    Browse the repository at this point in the history

  34. Add behaviors as an allowed key to BLOCK_EDITOR_SETTINGS

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3fd9270 View commit details
    Browse the repository at this point in the history

  35. Move the behaviors to top level in the e2e test theme.json file

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5a9748c View commit details
    Browse the repository at this point in the history

  36. Rename the behaviors setting to behaviorsUIEnabled

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9a6b1f2 View commit details
    Browse the repository at this point in the history

  37. Change "None" to "No behaviors"

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1c7f6d5 View commit details
    Browse the repository at this point in the history

  38. Behaviors -> behavior

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    470f74f View commit details
    Browse the repository at this point in the history

  39. Fix redundant ternary

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bba7c2d View commit details
    Browse the repository at this point in the history

  40. Improve the JSDoc for behaviors selector

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2cb348c View commit details
    Browse the repository at this point in the history

  41. Rename the test themes to make more sense

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c65bc57 View commit details
    Browse the repository at this point in the history

  42. Remove definition of behaviors attribute in core/image

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1c655f7 View commit details
    Browse the repository at this point in the history

  43. Change default value for behaviors.lightbox to false and update e2e… 

    … tests accordingly
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    697c04f View commit details
    Browse the repository at this point in the history

  44. Change the way we get the data from theme.json and adjust e2e

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d4fd9d9 View commit details
    Browse the repository at this point in the history

  45. Capitalize behaviors' labels

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a57d634 View commit details
    Browse the repository at this point in the history

  46. Move PHP code adding theme.json behaviors to block-editor-settings

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    234a8b6 View commit details
    Browse the repository at this point in the history

  47. Update comment

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4bef633 View commit details
    Browse the repository at this point in the history

  48. Remove the behaviors require from load.php

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7aa7231 View commit details
    Browse the repository at this point in the history

  49. Revert "Update comment" 

    This reverts commit fc812bc6c04e8b3c5c7fe3450c1e39d1dd6f6f3b.
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1d923ab View commit details
    Browse the repository at this point in the history

  50. Revert "Move PHP code adding theme.json behaviors to `block-editor-… 

    …settings`"

This reverts commit e8d16c8bb4977d1e27b758a067066a78fc21f794.
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    aee908a View commit details
    Browse the repository at this point in the history

  51. Remove the comment that was added previously

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    33cb62d View commit details
    Browse the repository at this point in the history

  52. Update comments in behaviors.php

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    55e37a3 View commit details
    Browse the repository at this point in the history

  53. Add back the require_once in load.php

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d4d657b View commit details
    Browse the repository at this point in the history

  54. Use settings.blocks.core/image.behaviors.lightbox

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8d6b0d0 View commit details
    Browse the repository at this point in the history

  55. Use behaviors.blocks.core/image.lightbox

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    76b2a75 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Remove experimental setting for interactivity API

    @cbravobernal
    cbravobernal committed May 24, 2023
    Configuration menu
    Copy the full SHA
    70e51cd View commit details
    Browse the repository at this point in the history

  2. Revert "Remove experimental setting for interactivity API" 

    This reverts commit 70e51cd.
    @cbravobernal
    cbravobernal committed May 24, 2023
    Configuration menu
    Copy the full SHA
    69ebe6c View commit details
    Browse the repository at this point in the history

  3. Move interactivity.js files to block.json

    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c32be86 View commit details
    Browse the repository at this point in the history

  4. Remove experimental flag for the Interactivity API

    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b8dc7dd View commit details
    Browse the repository at this point in the history

  5. Revert "Move interactivity.js files to block.json" 

    This reverts commit c32be86.
    @michalczaplinski
    michalczaplinski committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4800d91 View commit details
    Browse the repository at this point in the history

  6. Revert "Remove experimental flag for the Interactivity API" 

    This reverts commit b8dc7dd.
    @michalczaplinski
    michalczaplinski committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9124b58 View commit details
    Browse the repository at this point in the history