useInstanceId: Fix useMemo hook dependencies

[Mamaduka]

What?

PR fixes useMemo dependencies for the useInstanceId hook.

Why?

To avoid returning the stale values when preferredId or prefix change during render.

Testing Instructions

An example plugin for testing.

const { createElement: el, useState } = wp.element;
const { useSelect } = wp.data;
const { CheckboxControl } = wp.components;
const { useInstanceId } = wp.compose;
const registerPlugin = wp.plugins.registerPlugin;
const PluginDocumentSettingPanel = wp.editPost.PluginDocumentSettingPanel;

function MyDocumentSettingPlugin() {
    const [ isChecked, setChecked ] = useState( false );
	const id = useInstanceId( MyDocumentSettingPlugin, 'instance-prefix', isChecked ? 'custom-id' : undefined )

	return el(
		PluginDocumentSettingPanel,
		{
			className: 'test-checkbox',
			title: 'Test Checkbox',
		},
		el( CheckboxControl, {
            // id: 'test-foo', 
            checked: isChecked,
            label: 'Use custom Id',
            onChange: (value) => setChecked(value),
        } ),
		el( 'p', {}, id )
	);
}

registerPlugin( 'test-checkbox', {
	render: MyDocumentSettingPlugin,
} );

Screenshots or screencast

Before

CleanShot.2023-04-21.at.10.00.00.mp4

After

CleanShot.2023-04-21.at.10.00.41.mp4

[tyxla]

LGTM 👍 Nice catch!

[github-actions]

Flaky tests detected in bdc91e9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4761964063
📝 Reported issues:

• [Flaky Test] dims the background image down by 50% when transformed from the Image block #47052 in specs/editor/blocks/cover.test.js
• [Flaky Test] should be able to create an hierarchical post without title support #36939 in specs/editor/plugins/custom-post-types.test.js