Fix fixed block toolbar positioning #49990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
jasmussen
approved these changes
Apr 21, 2023
| @@ -250,35 +260,7 @@ | |||
| // except for the inserter on the left | |||
| @include break-medium() { | |||
| &.is-fixed { | |||
|
|
|||
There was a problem hiding this comment.
This was so painful to write I almost felt sorry ahahhaha
There was a problem hiding this comment.
For what it's worth, this behavior feels pretty solid now, and knowing the mixin has been used for the main editor window for years now should also boost confidence here, IMO. In fact, I hope to mock up a version of this for mobile next week :)
Co-authored-by: Joen A. <1204802+jasmussen@users.noreply.github.com>
|
Size Change: -22 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 373d49d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4765988912
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49988
Why?
Using the chimeric
.auto-foldclass to target states of the WP admin was wrong since starting at large viewports does not contain this class, hence breaking expectations.How?
Using the
editor-leftmixin to calculate the left position which takes into account all states of WP admin (full screen, not full screen, expanded sidebar etc).Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast