Remove the normalizeFalsyValue util #50033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
tyxla
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
LGTM 👍
After your explanation I can see some value in what you explained in the normalizeFalsyValue, it just felt like it's not in the right place. Perhaps we should place it somewhere else though? One potential location to put it could be this README file.
|
I think given that I think that the behavior of "removing falsy" values which we historically relied upon on global styles is wrong. (Instead we should have reset links), I think it's fine to omit the documentation for now. |
|
Size Change: -22 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a comment here #49750 (comment)
What?
Basically, this util didn't feel like a great one to have as opposed to just inlinining
|| undefined