Use apiFetch instead of window.fetch #50043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +64 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
cc @youknowriad, since you added this originally. |
scruffian
approved these changes
Apr 24, 2023
15 tasks
getdave
reviewed
Apr 25, 2023
youknowriad
reviewed
Apr 25, 2023
| let template; | ||
| try { | ||
| template = await window |
There was a problem hiding this comment.
I don't recall exactly why initially apiFetch didn't work for me 🤔 I wonder what changed.
scruffian
force-pushed
the
fix/refactor-template-api-fetch
branch
from
cb2bdd7
to
aec5367
Compare
bph
added
[Type] Code Quality
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This replaces the native use of window.fetch with a a call to apiFetch, so that it uses the Gutenberg functions.
🤖 Generated by Copilot at cb2bdd7
Refactored
core-datapackage to useapiFetchfor all REST API requests. This improves data fetching consistency and reliability, and enables future endpoint enhancements.Why?
This means that this when changes are made to the REST API (for example https://github.com/WordPress/gutenberg/pull/50030/files), this API call will also be updated.
How?
Replace window.fetch with apiFetch.
🤖 Generated by Copilot at cb2bdd7
core-datapackage to use theapiFetchutility instead of thewindow.fetchAPI (link, FTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Co-authored-by: Maggie 3593343+MaggieCabrera@users.noreply.github.com