Migrate PullQuote test case to playwright #50085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanpatil1
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
skorasaurus
added
the
[Type] Automated Testing
|
Hi! Thanks for the PR! Have you read the latest migration guide as noted in #38851 (comment) ? I noticed some places are still a bit outdated, could you help refactor them with the best practices in mind? |
kevin940726
reviewed
Apr 27, 2023
|
Hi @kevin940726, Updated the test case as per your suggestion. Could you please check again? |
kevin940726
reviewed
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate pullquote.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/blocks/pullquote.spec.js