File Block: Defer hiding PDF embeds for unsupported browsers until the page has loaded #50113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 915c7d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4814442013
|
gziolo
added
the
Good First Review
gziolo
approved these changes
Apr 28, 2023
|
I tested it locally and it works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Instead of calling
hidePdfEmbedsOnUnsupportedBrowsersimmediately when the File block's view script loads (in thehead), wait until the DOM has loaded.Why?
Currently all of a block's view scripts are loaded in the
head(see Core-54018). The Navigation block's view scripts run their logic at the windowloadevent (cf. #42394 (comment)). The File block, however, does not use any such event listener to run itshidePdfEmbedsOnUnsupportedBrowserslogic. This means that currently no PDF embeds are being hidden on unsupported browsers. I'm surprised that this hasn't been noticed before now, since such embeds don't work on mobile devices. For example, see the WordPress.com Support Page for Embed a PDF File in Chrome for Android:Testing Instructions