List View / Block Draggable: Fix scroll to top issue when dragging the second last block in the list #50119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
noisysocks,
talldan,
apeatling,
ramonjd and
tellthemachines
|
Size Change: +11 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Apr 27, 2023
|
Thanks for reviewing! |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #49563
Update the scrolling logic within BlockDraggable's
useScrollWhenDragginghook so that it doesn't accidentally flick the scrolling to the top of the scrollable container. This sometimes happens in the list view, most reliably when dragging the second last view view item to the bottom of the list view.Why?
Prior to this PR, if the drag position is within the bottom
50pxof the scrollable container (that is, withinSCROLL_INACTIVE_DISTANCE_PX), then the calculations formoveableDistanceanddragDistancecan become0. This causes issues whenmoveableDistanceis positive butdragDistanceis0as that results in a divide by zero error which causes the velocity to beInfinity. E.g. I observedmoveableDistanceas sometimes being4whiledragDistanceis0which results in adistancePercentageofInfinity(4 / 0 === Infinity).How?
In the
scrollOnDragOverlogic that checks fordistancePercentageensure that if eithermoveableDistanceordragDistanceis0, then treat it as adistancePercentageof0to avoid accidentally setting a velocity ofInfinityTesting Instructions
trunk(other than this fix, the existing behaviour should be otherwise unaffacted)Screenshots or screencast