Command Center: Fix a style glitch on Safari #50138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Should this live as an inline style, or in a separate CSS file? Asking mostly out of curiosity as my instinct would've been the latter, but curious to your reasons. Can you try the more standardized |
|
Size Change: +36 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Yeah no preference here :) I'll make your suggested updates. |
jasmussen
reviewed
Apr 27, 2023
| @@ -36,6 +36,9 @@ | |||
| } | |||
|
|
|||
| .commands-command-menu__container { | |||
| // the style here is a hack to force safari to repaint to avoid a style glitch | |||
There was a problem hiding this comment.
I know this is terribly nitpicky, but do we have a standard for code comments? I normally use sentence capitalization and end with a period 🙈
It's not a strong opinion, we just have a mix of styles.
|
Flaky tests detected in 426af33. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4820493059
|
|
Let's get this in :) |
bph
added
[Type] Experimental
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #48457
What?
In Safari, as you type in the command center (cmd+k) you can see some visual glitches in the modal. I'm thinking this is probably a Safari bug but I wasn't able to find the root cause. The current PR solves the issue by forcing a browser repaint on render (using the transform style).
Testing Instructions