Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Post Link block variation icon to match the one used in the Link UI results. #50190

Merged
merged 4 commits into from
May 25, 2023
Merged

Update Post Link block variation icon to match the one used in the Link UI results. #50190

merged 4 commits into from
May 25, 2023

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Apr 28, 2023

What?

Update Post Link block variation icon to match the one used in the Link UI results.

Fixes #50181

Testing Instructions

  1. Go to the site editor.
  2. Edit the header, and select the navigation block.
  3. Add a new post link.
  4. Confirm that the icon is the same as the one used in the link UI results.

Screenshots or screencast

Screen.Recording.2023-04-28.at.18.25.24.mov

@juanfra juanfra self-assigned this May 22, 2023
@juanfra juanfra added [Block] Navigation Link Affects the Navigation Link Block [Type] Enhancement A suggestion for improvement. labels May 22, 2023
@getdave getdave requested a review from richtabor May 22, 2023 09:13
@getdave
Copy link
Contributor

getdave commented May 22, 2023

Thank you! On my review list for this week.

@jameskoster
Copy link
Contributor

Since we're using the page icon for Page Link, we should probably use the post icon for Post Link?

@jameskoster jameskoster requested a review from a team May 22, 2023 12:52
@juanfra
Copy link
Member Author

juanfra commented May 25, 2023

Thank you! To add more context for the design review, this is how it'd look with the post icon, and the postList

postList icon.

Screenshot 2023-05-25 at 12 23 15

post icon.

Screenshot 2023-05-25 at 12 27 00

@jameskoster
Copy link
Contributor

post makes more sense to me, seeing as the link is to a single post rather than a list/archive. I don't love the post icon itself, but that's not something to address here.

richtabor
richtabor approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richtabor richtabor merged commit f373afe into WordPress:trunk May 25, 2023
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone May 25, 2023
@juanfra juanfra deleted the fix/50181-update-icon branch May 26, 2023 14:13
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@femkreations femkreations mentioned this pull request Jul 12, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtabor richtabor richtabor approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@getdave getdave Awaiting requested review from getdave

@jameskoster jameskoster Awaiting requested review from jameskoster

Assignees

@juanfra juanfra

Labels
[Block] Navigation Link Affects the Navigation Link Block Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 16.0
Development

Successfully merging this pull request may close these issues.

Update Post Link block variation icon to match the one used in the Link UI search results
5 participants
@juanfra @getdave @jameskoster @richtabor @femkreations