Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gutenberg plugin mention in schema #50207

Merged
merged 1 commit into from
May 4, 2023
Merged

Remove gutenberg plugin mention in schema #50207

merged 1 commit into from
May 4, 2023

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Apr 30, 2023

What?

Remove "Gutenberg plugin required." from schema.

Why?

  • The schema is the Gutenberg version of the schema, so it is redundant.
  • The schemas are not processed for release, so inclusion of this comment will be incorrect after a release.

How?

Remove "Gutenberg plugin required." from schema.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ajlende ajlende added the [Type] Bug An existing feature does not function as intended label Apr 30, 2023
@ajlende ajlende self-assigned this Apr 30, 2023
scruffian
scruffian approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@scruffian scruffian enabled auto-merge (squash) May 4, 2023 10:31
@github-actions
Copy link

github-actions bot commented May 4, 2023

Flaky tests detected in 073fb38.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4843722511
📝 Reported issues:

@scruffian scruffian mentioned this pull request May 4, 2023
Merged
@scruffian scruffian force-pushed the fix/remove-gutenberg-plugin-mention-in-schema branch from 073fb38 to 50931fe Compare May 4, 2023 11:22
@scruffian scruffian merged commit 82b9843 into trunk May 4, 2023
@scruffian scruffian deleted the fix/remove-gutenberg-plugin-mention-in-schema branch May 4, 2023 11:57
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 4, 2023
@bph bph added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label May 8, 2023
@bph bph mentioned this pull request May 8, 2023
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy

Assignees

@ajlende ajlende

Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.8
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlende @scruffian @bph