Fix command menu not re-opening after closing it #50213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +18 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
May 1, 2023
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #48457
What?
In trunk when you close the command menu, the focus is lost which means we're unable to open the menu again if we hit
cmd + k. The current PR solves that.How?
autoFocusprop shouldn't be used to auto focus inputs because it's performed too early in the React lifecycle causinguseFocusReturnto break.Testing Instructions
1- Enable the "command center" experiment
2- Open the site editor
3- Focus anything in the page
4- Hit cmd + k
5- The command center is open and focus
6- Hit escape
7- Hit cmd + k again
8- The command center should open again.