Fix site logo preview image size with long filenames #50242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
jasmussen
approved these changes
May 2, 2023
| @@ -139,6 +139,7 @@ | |||
|
|
|||
| img { | |||
| width: $grid-unit-50 * 0.5; | |||
| min-width: $grid-unit-50 * 0.5; | |||
There was a problem hiding this comment.
We probably need a separate variable for this size. There's $radio-input-size, but it might be worth either creating another, or renaming that one so we have a single size for this. Can even be a new $grid-unit-25. But short of doing that, maybe it's fine to just type out 20px?
There was a problem hiding this comment.
I'll trust your judgement about this and will update the code. If the new designs(or some current ones are using the 20px value, I can create a new var. Alternatively I can hardcode the 20px for now.
|
Size Change: +14 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 3, 2023
ntsekouras
added
the
Backport to Gutenberg RC
|
@bph This should be included in 15.7 release. |
|
I just cherry-picked this PR to the release/15.7 branch to get it included in the next release: fe2949b |
bph
pushed a commit
that referenced
this pull request
May 3, 2023
* Fix site logo preview image size with long filenames * hardcode width value
bph
removed
the
Backport to Gutenberg RC
|
Thanks all! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #49992 (comment)
As noted by @ndiego , when a logo has a big filename(results to truncated text) the image icon preview doesn't preserve the
20pxwanted width. This was due to someHStackcss conflict and this PR fixes that.