Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce prepend_to_selector() to avoid additional if checks and follow single responsibility principle #50266

Merged
merged 4 commits into from
May 23, 2023
Merged

Introduce prepend_to_selector() to avoid additional if checks and follow single responsibility principle #50266

merged 4 commits into from
May 23, 2023

Commits on May 2, 2023

  1. Introduce prepend_to_selector() method to avoid additional if checks … 

    …and follow single responsibility principle.
    @felixarntz
    felixarntz committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7e8cc35 View commit details
    Browse the repository at this point in the history

  2. Don't call append_to_selector() when selector is likely empty.

    @felixarntz
    felixarntz committed May 2, 2023
    Configuration menu
    Copy the full SHA
    45473d9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Remove parameter completely instead of deprecating.

    @felixarntz
    felixarntz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b9c0312 View commit details
    Browse the repository at this point in the history

  2. Correct doc block.

    @felixarntz
    felixarntz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    32332f8 View commit details
    Browse the repository at this point in the history