Update has-text has-icon button spacing #50277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Package] Components
|
Size Change: +4 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Hah, nice. Is this similar to #50241? Agreed, gap is nice. The left padding in this case does not look balanced in either before or after, though
I know that's likely partially due to the visible area of the icon, and the built in clearance. But perhaps a grid unit 10 padding left, instead of grid-unit-15? |
|
Oh yes, pretty similar :)
Yes that's it. To get visually correct spacing with most of the core icon set, the spacing on the left should be 4px less than the spacing on the right. We can do that, but there will always be exceptions to the rule that will look strange. I suppose that's the preferred trade-off though. I'll push an update. |
|
Needs a rebase! Thanks Jay. |
jameskoster
added
the
Design System
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the padding applied the
has-text has-iconbuttons. Also reduces the spacing between label + icon, and usesgaprather thanmargin.Why?
The current spacing feels a but unbalanced.
gapworks better for RTL compared to left/right margin.How?
CSS.
Testing Instructions
Observe equal left/right padding applied to
has-text has-iconlike the View button in the Top Bar.Comparison
Note: The outline in the screenshot above is for illustrative purposes only. Here's how the button actually appears: