Color panel: add button aria labels #50307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Focus] Accessibility (a11y)
4 tasks
|
Size Change: +89 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
No longer required after #50089 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hi, how are you?
Over at #50089 I needed a way to access color panel buttons for E2E tests similar to those we find on the typography style options.
Finding none, I added them.
Why?
There were no aria labels on the color panel subgroup buttons. I'm talking about
Color > Text,Color > Backroundand so on.It's also very handy should we wish to access these elements via label selectors in our E2E tests.
Before
After
Testing Instructions
Open the styles panel in the site editor or select any block that has color support.
For the color categories, e.g., text, background, etc check that the button element has the appropriate aria label, e.g.,
"Color Heading styles"Make sure that the E2E tests pass as well!
Thank you!