Fix Multiple Tooltips from Focus Toolbar Shortcut on Widget Editor #50344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +68 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jeryj
force-pushed
the
fix/multiple-tooltips-widgets-editor
branch
from
c62b9f2 to
4c48232
Compare
jeryj
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
kevin940726 and
ellatrix
as code owners
jeryj
changed the title
… to simplify the code and apply it to the Widgets Editor.
draganescu
force-pushed
the
fix/multiple-tooltips-widgets-editor
branch
from
4c48232 to
e5c3cab
Compare
draganescu
approved these changes
May 5, 2023
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49926
What?/Why?
Fixes multiple tooltips being visible when using the focus toolbar shortcut (alt + F10) on the Widgets Editor.
How?
useShouldContextualToolbarShow()from Fix multiple tooltips showing on NavigableToolbars #49644.useShouldContextualToolbarShow()to make it require less code to connect to the Widgets Header (and also the Site Editor in a separate PR).Testing Instructions
Testing Instructions for Keyboard
Switch to a theme with widgets, such as Twenty Nineteen, and go to the widgets editor page:
/wp-admin/widgets.phpBlock toolbar open
alt + F10(orfn + option + F10on mac keyboards)No selected blocks
alt + F10(orfn + option + F10on mac keyboards)In Select Mode
alt + F10(orfn + option + F10on mac keyboards)From the + Button
alt + F10(orfn + option + F10on mac keyboards)Basically, try to break it using all of the different view modes (Top Toolbar on/off, Spotlight mode, etc) and with an empty default blocks selected, a block selected, multiple blocks selected, etc. Anytime a block toolbar is showing, it should receive focus with the
alt + F10shortcut, and anytime it's not showing, focus should be in the top toolbar.Screenshots or screencast
Broken State: Only one tooltip should show
