Update PHP docblock for WP_Theme_JSON_Gutenberg::get_property_value
#50527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnajian
force-pushed
the
fix/remove-obsolete-method-docblock
branch
from
1522249 to
4b90d6f
Compare
oandregal
approved these changes
May 11, 2023
samnajian
force-pushed
the
fix/remove-obsolete-method-docblock
branch
from
4b90d6f to
019b6c5
Compare
oandregal
changed the title
WP_Theme_JSON_Gutenberg::get_property_value
|
Backport at WordPress/wordpress-develop#4556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Per this PR the conversation of
var:preset|color|secondaryto--wp--preset--color--secondaryis now happening in the constructor, there is no need to do it inget_property_valueso that's updated in 50366, but the docblock had stayed the same.