[Mobile] EmptyList now uses useEditorWrapperStyles hook and removes ReadableContentView
#50552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
May 11, 2023
|
I imagine it likely makes sense to first merge #50447 and then update this to target the |
Exactly, let's do that 👍 |
added 2 commits
May 12, 2023 14:35
geriux
force-pushed
the
perf/empty-list-component-uses-wrapper-styles-hook
branch
from
bbc3169
to
e345b9a
Compare
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes wordpress-mobile/gutenberg-mobile#5618
Related PRs:
useEditorWrapperStyleshook and removesReadableContentViewwordpress-mobile/gutenberg-mobile#5764What?
Follow up of #50447 it updates the last component pending to use the
useEditorWrapperStyleshook.Why?
The
EmptyListcomponent in the BlockList was still using theReadableContentViewcomponent.How?
By updating the component to use the
useEditorWrapperStyleshook. It also removes theReadableContentViewcomponent from the codebase.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast