Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gutenberg_get_remote_theme_patterns #50597

Merged
merged 2 commits into from
May 15, 2023

Conversation

oandregal
Copy link
Member

Follow-up to #50310
Related #50596

What

This PR moves gutenberg_get_remote_theme_patterns from: lib/compat/wordpress-6.3/get-global-styles-and-settings.php to lib/global-styles-and-settings.php

Why?

The reason is that while the global styles APIs continue to be developed, we need the public API to use the gutenberg classes.

How?

Move the function from one file to another verbatim.

Testing Instructions

Verify automated test pass.

@oandregal oandregal requested a review from Mamaduka May 12, 2023 14:37
@oandregal oandregal self-assigned this May 12, 2023
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label May 12, 2023
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

✅ Relocated code matches
✅ Tests are passing

@oandregal oandregal force-pushed the move/get-remote-theme-patterns branch from 1a7bab1 to 3e20ed4 Compare May 15, 2023 07:16
@oandregal oandregal merged commit d66e670 into trunk May 15, 2023
@oandregal oandregal deleted the move/get-remote-theme-patterns branch May 15, 2023 07:59
@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 15, 2023
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 5, 2023
@oandregal
Copy link
Member Author

This PR moves code that was introduced at #49307

The backport PR for both of them is at WordPress/wordpress-develop#4543

@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants