update the site editor title bar #50653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -120 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Nice, fast work! This is looking great to me, and feels really close to landing:
What's missing? One issue, but this may be an issue in trunk as well:
From that point on, it is enough to press ⌘ to invoke the command bar. |
|
A couple of tiny details: It looks like the portions are all 1/3 of the overall title bar width. I wonder if the title should be slightly wider to avoid overly keen truncation: 
The template icon seems to grow/shrink with the overall width: 
Does the command icon need to be an svg? The ⌘ glyph seems to work fine, but perhaps it's not available in all fonts? If we fix the above, and assuming we'll populate the title bar with page details as a part of #49980, then I'd say we're good to go. |
|
Oh we probably need some mobile considerations as well. Here's one sketch: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the site editor title bar to trigger command center and prepares for when #49980 lands.
Why?
Addresses #50378
How?
Optional
backprop.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
title-bar.mp4