Integrate prioritizedInserterBlocks API to slash inserter
#50658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Inserter
ntsekouras
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
|
Size Change: +49 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 16, 2023
There was a problem hiding this comment.
Nice work, @ntsekouras!
P.S. I noticed that the new E2E test introduced in #50510 uses Puppeteer; we recommend using Playwright for new tests to avoid adding more work to the migration process.
Maybe we can migrate these tests as a follow-up. cc @scruffian, @getdave
ntsekouras
deleted the
add/prioritizedInserterBlocks-api-to-slash-inserter
branch
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #50635
Follow up of: #50510
This PR integrates the
prioritizedInserterBlocksAPI to the slash inserter.Testing Instructions
prioritizedInserterBlocksAPI. For example you can add this:prioritizedInserterBlocks: [ 'core/site-logo' ]to the Group block here./to trigger the slash inserter.